fix: draft() can't resolve TypeScript helper functions defined in logic/logic.ts (#147)

[mttrbrts]

Summary

Fixes #147.

TemplateArchiveProcessor.draft() was compiling each inline formula
({{% expr %}}) with a TypeScript context that did not include
the template's user code from logic/logic.ts. As a result, helper
functions like monthlyPaymentFormula(...) produced
Cannot find name 'monthlyPaymentFormula' (TS2304) and drafting failed
on otherwise valid templates (repro: cicero-template-library PR #484
src/fixed-interests).

trigger() and init() were already loading logic/logic.ts via
TypeScriptToJavaScriptCompiler. They just didn't share that work with
draft().

Fix

• Extracted the existing trigger/init compilation into a shared helper
  compileUserLogic (src/UserLogic.ts). It returns the compiled JS
  along with the top-level identifiers (function, class,
  const/let/var) it declares and a copy of that JS with import/
  export syntax stripped so it can be spliced into a new Function
  body.
• TypeScriptCompilationContext now emits declare const <name>: any;
  for each declared identifier, so user helpers type-check inside
  formula expressions.
• TemplateMarkInterpreter accepts a CompiledUserLogic and threads
  the runtime prelude through to the JS formula evaluator, so the same
  identifiers are real values at evaluation time.
• TemplateArchiveProcessor:
  • draft() now calls compileLogic() and passes the result into the
    interpreter.
  • trigger() and init() were refactored to call the same
    compileLogic() helper, so all three code paths now load logic via
    the same path.

Repro / test

Added test/archives/formula-uses-logic-helper: a minimal template
fixture whose grammar contains {{% return calc(penaltyPercentage); %}}
where calc is a helper function declared in logic/logic.ts.

The new test in test/TemplateArchiveProcessor.test.ts:

• Fails on main with TS2304: Cannot find name 'calc'.
• Passes with this change (calc(10.5) === 26.25).

Test plan

• Reproduce TS2304 with a minimal fixture before the fix.
• New unit test passes with the fix applied.
• Existing should draft a template still passes (template with
  logic.ts but no helper-calling formula).
• Existing should trigger a template / should init a template
  still pass after refactor to shared helper.
• npx eslint src/ test/ — no new errors.
• CI to run the full suite. (Network-restricted local environment
  blocks models.accordproject.org, so some unrelated tests fail
  locally on main too.)

---

Generated by Claude Code

[coveralls]

Coverage Report for CI Build 25955964043

Coverage increased (+0.6%) to 64.788%

Details

• Coverage increased (+0.6%) from the base build.
• Patch coverage: 4 uncovered changes across 1 file (70 of 74 lines covered, 94.59%).
• 2 coverage regressions across 1 file.

Uncovered Changes

File	Changed	Covered	%
src/TemplateArchiveProcessor.ts	29	25	86.21%

Coverage Regressions

2 previously-covered lines in 1 file lost coverage.

File	Lines Losing Coverage	Coverage
src/TemplateArchiveProcessor.ts	2	78.48%

---

Coverage Stats

Relevant Lines:	1154
Covered Lines:	743
Line Coverage:	64.38%
Relevant Branches:	567
Covered Branches:	372
Branch Coverage:	65.61%
Branches in Coverage %:	Yes
Coverage Strength:	5781.61 hits per line

---

💛 - Coveralls