fix(html): correctly handle <caption> element in HTML table deserialization#672
Open
Satvik77777 wants to merge 1 commit into
Open
fix(html): correctly handle <caption> element in HTML table deserialization#672Satvik77777 wants to merge 1 commit into
Satvik77777 wants to merge 1 commit into
Conversation
Signed-off-by: Satvik <satviksaini02@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #635
Problem
HTML tables with a
<caption>element produced broken Markdown output — each cell rendered on its own line instead of a valid table row:Before (broken): Employee Details
| | Name
| Role
|
| Alice
| Engineer
|
Root Cause
The
<caption>element was being processed as a regular table child node, corrupting theTableHead/TableBodystructure during deserialization. This caused the table rows to break apart into individual lines.Fix
<caption>directly from the DOM before processing table children — no leaking intermediate nodesParagraphblock before the table (plain text, noStrongwrapping of arbitrary content, no\n\ntext injection)TableHead/TableBodyonly, ignoring other child nodesthcells and notheadexistscleanTableNodes()to removeSoftbreaknodes and merge adjacentTextnodesNote on #640
This PR addresses the same issue as #640 but resolves all review feedback that blocked that PR from merging:
type: 'caption'nodesStrongwrapping of arbitrary block content\n\ntext node hack inside ParagraphChecklist
--signoff)