Fix HTML rendering of relationship variables in CiceroMark#637
Fix HTML rendering of relationship variables in CiceroMark#637Aradhana2803 wants to merge 3 commits into
Conversation
Signed-off-by: aradhana2803 <aradhanasingh2803@gmail.com> git push --force origin fix/relationship-variable-html
154e571 to
7c5caf5
Compare
|
This PR fixes the issue reported in template-playground#13 where relationship-typed CiceroMark variables were rendered as quoted resource: strings instead of a readable identifier. HTML rendering now preserves the identifier cleanly, while keeping other variable types unchanged.Verified that |
sanketshevkar
left a comment
There was a problem hiding this comment.
Can you please add unit tests covering this case?
Replace hardcoded namespace prefix check with identifiedBy, which is the canonical Concerto marker for relationship/reference types. Only strip the resource URI (resource:namespace#identifier) scheme when the value actually carries that prefix, leaving primitive quoted values unchanged so existing tests are unaffected. Add unit tests covering quoted resource URI, bare resource URI, and primitive variable rendering. Signed-off-by: Matt Roberts <matt@rbrts.uk> Signed-off-by: Matt Roberts <code@rbrts.uk>
|
@sanketshevkar I've pushed an updated commit on top of this branch that addresses your review.
The original check used Unit tests added Three cases in a new
All 65 existing tests still pass. |
…c lint rule Signed-off-by: Matt Roberts <matt@rbrts.uk> Signed-off-by: Matt Roberts <code@rbrts.uk>
Fix HTML rendering of relationship variables in CiceroMark
Related to accordproject/template-playground#13
Summary
Relationship-typed CiceroMark variables were rendered in HTML as quoted
resource:strings instead of a readable identifier. This PR fixes theHTML rendering logic so relationship variables display correctly.[TemplateMark not rendering relationships "resource" data #13]
Changes
ToHtmlStringVisitorto detect relationship variables viaelementTypeFlags
Screenshots or Video
Not applicable — behavior verified via existing HtmlTransformer test suite.
Author Checklist
--signoffoption of git commitmainfromfork:branchname