Connectors: Replace plugin.slug with plugin.file

[jorgefilipecosta]

Summary

• Replace plugin.slug with plugin.file (the full plugin file path, e.g. akismet/akismet.php) in connector registrations
• Simplify script module data: remove get_plugins() slug-to-file map, use file_exists() and is_plugin_active() directly
• Add isInstalled to the frontend plugin data
• Update PHPDoc for plugin type across registry and public API functions

Ticket: https://core.trac.wordpress.org/ticket/65002

Test plan

• Verify connectors page loads and shows correct plugin status
• Verify install and activate flows still work for AI provider plugins

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jorgefilipecosta, mukesh27, gziolo.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[mukeshpanchal27]

Thanks for the PR!

Have you consider single file plugin (hello.php)?

[gziolo]

Have you consider single file plugin (hello.php)?

This should work, too. Worth including in the PHPDoc for completeness.

[gziolo]

@jorgefilipecosta, to test it in the browser we need to land Gutenberg changes and update the hash to have JS changes compatible?

[jorgefilipecosta]

@jorgefilipecosta, to test it in the browser we need to land Gutenberg changes and update the hash to have JS changes compatible?

Exactly or we can test this together with Gutenberg plugin activated.

[gziolo]

The existing test test_register_includes_plugin_data in tests/phpunit/tests/connectors/wpConnectorRegistry.php:297 still uses 'slug' => 'my-plugin' and passes because the registry stores whatever keys are provided in the plugin array without validation. This should be updated to use 'file' to match the new contract:

$args['plugin'] = array( 'file' => 'my-plugin/my-plugin.php' );

$this->assertSame( array( 'file' => 'my-plugin/my-plugin.php' ), $result['plugin'] );

This also flags that the registry might benefit from cherry-picking known properties from the plugin array (i.e., only keeping file) rather than storing whatever is passed in. That way invalid keys would be silently dropped and the stored data would always match the documented shape. It still works properly because we do that sanitization when passing data to the client.

[gziolo]

One small tweak to ensure OS compatibility and this is good to go. Thank you for addressing all feedback.

[gziolo]

It would be best to normalize the file name with wp_normalize_path to avoid issues with differences in how the path is constructed depending on the OS.

[github-actions]

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 62192
GitHub commit: d368a44

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.