Connectors: Register Akismet Anti-Spam as a default connector

[jorgefilipecosta]

Summary

Register Akismet Anti-Spam as a built-in non-AI connector with spam_filtering type.

• Uses the existing wordpress_api_key WordPress option for API key storage
• Checks the WPCOM_API_KEY PHP constant

Testing

Verify the akismet connector works as expected:

• Test the default activation flow.
• Delete Akismet and test the installation flow. Set an Akismet key verify it shows as connected, on the connectors and on the Akismet own settings page.
• Set a key on Akismet settings page verify it is reflected on the connectors screen.
• Set a key using wp-config define( 'WPCOM_API_KEY', 'your-key' ); verify the connectors reflect the key was set on wp-config.

See also: WordPress/gutenberg#76828

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @1178653+wordpress-develop-pr-bot[bot]@users.noreply.github.com.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jorgefilipecosta, bluefuton, gziolo.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[jorgefilipecosta]

Only this part is relevant the rest is Gutenberg ref update which is included for testing but will not be part of the commit.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[github-actions]

Trac Ticket Missing

This pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac.

To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook.

[bluefuton]

One note on resetting API keys - it's not possible for the user to reset their API key on akismet.com, so we should hide this text for Akismet.

[gziolo]

@bluefuton, can we change the copy to a more generic version, like:

You can manage it at akismet.com

[gziolo]

@jorgefilipecosta, I was thinking about it. Akismet is using a custom setting name, which means they already control it and register themselves. In that case, I think it's fair to assume that WP core doesn't need to handle it. If it is needed for testing purposes, we can always mock it for individual tests.

Concluding, let's auto-register the setting name only when not set explicitly. AI is a bit awkward in that regard, so maybe we can add a special case there, too.

[gziolo]

Just checking, does the setting need to be registered before plugin installation for JS to function properly?

[gziolo]

I investigate it further, and it looks like the setting gets registered only if the plugin doesn't do it earlier. It seems like a sound approach. In that case, it's only the fallback in WP core.

Unfortunately, I can't think of a simple way to prevent such registration when Akismet isn't installed. Well, what I said earlier still holds. However, it might not be trivial to achieve such a goal.