Switch electronics cooling fan from a heater_fan to a controller_fan#323
Open
amadea-system wants to merge 2 commits intoVoronDesign:Voron2.4from
Open
Switch electronics cooling fan from a heater_fan to a controller_fan#323amadea-system wants to merge 2 commits intoVoronDesign:Voron2.4from
heater_fan to a controller_fan#323amadea-system wants to merge 2 commits intoVoronDesign:Voron2.4from
Conversation
Switch to using the `controller_fan` module for the electronics cooling fans on the SKR1.3, SKR1.4, & Spider Klipper Configs
nemgrea
approved these changes
Jul 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to using the
controller_fanmodule for the electronics cooling fans on the SKR1.3, SKR1.4, & Spider Klipper configs.This will bring those configs inline with the electronics cooling fans setting in the Octopus Klipper config.
This change has been tested on the SKR1.3 (by me) and presumably the Octopus since that's already in the repo.