Skip to content

vmagent: support per remoteWrite queues configuration#2139

Open
AndrewChubatiuk wants to merge 1 commit into
masterfrom
per-rw-queues
Open

vmagent: support per remoteWrite queues configuration#2139
AndrewChubatiuk wants to merge 1 commit into
masterfrom
per-rw-queues

Conversation

@AndrewChubatiuk
Copy link
Copy Markdown
Contributor

@AndrewChubatiuk AndrewChubatiuk commented May 6, 2026

fixes #2138


Summary by cubic

Adds per-target remote write queues in VMAgent, with fallback to global remoteWriteSettings.queues. This lets each remote write URL use its own queue count.

  • New Features
    • Added queues to VMAgentRemoteWriteSpec; CRD schema, API docs, and changelog updated.
    • Controller emits -remoteWrite.queues aligned with -remoteWrite.url: if any per-target value is set, outputs a comma-separated list (missing entries use the global value); otherwise emits a single global flag.

Written for commit e151d01. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 10 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="internal/controller/operator/factory/vmagent/vmagent.go">

<violation number="1" location="internal/controller/operator/factory/vmagent/vmagent.go:1030">
P1: `hasAnyQueuesSet` is set too broadly, which can drop `-remoteWrite.queues` entirely when explicit per-URL values equal the global queue value.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.

Comment thread internal/controller/operator/factory/vmagent/vmagent.go
Comment thread internal/controller/operator/factory/vmagent/vmagent.go Outdated
Comment thread internal/controller/operator/factory/vmagent/vmagent.go Outdated
Comment thread internal/controller/operator/factory/vmagent/vmagent.go
Comment thread internal/controller/operator/factory/vmagent/vmagent.go Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting different queues for each remoteWrite in VMAgent CR

2 participants