vmagent: support per remoteWrite queues configuration#2139
Open
AndrewChubatiuk wants to merge 1 commit into
Open
vmagent: support per remoteWrite queues configuration#2139AndrewChubatiuk wants to merge 1 commit into
AndrewChubatiuk wants to merge 1 commit into
Conversation
12c7c04 to
02f98e7
Compare
Contributor
There was a problem hiding this comment.
1 issue found across 10 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="internal/controller/operator/factory/vmagent/vmagent.go">
<violation number="1" location="internal/controller/operator/factory/vmagent/vmagent.go:1030">
P1: `hasAnyQueuesSet` is set too broadly, which can drop `-remoteWrite.queues` entirely when explicit per-URL values equal the global queue value.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
vrutkovs
requested changes
May 12, 2026
85c7fb9 to
e151d01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2138
Summary by cubic
Adds per-target remote write queues in
VMAgent, with fallback to globalremoteWriteSettings.queues. This lets each remote write URL use its own queue count.queuestoVMAgentRemoteWriteSpec; CRD schema, API docs, and changelog updated.-remoteWrite.queuesaligned with-remoteWrite.url: if any per-target value is set, outputs a comma-separated list (missing entries use the global value); otherwise emits a single global flag.Written for commit e151d01. Summary will update on new commits.