reconcile: prevent from staying in expanding state#2124
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
AndrewChubatiuk
force-pushed
the
fix-prevent-from-hanging-in-expanding
branch
from
b7e95c8 to
c31c75d
Compare
vrutkovs
reviewed
May 7, 2026
Comment on lines
344
to
+349
| if reconcile.IsRetryable(err) { | ||
| resultStatus = vmv1beta1.UpdateStatusExpanding | ||
| } else { | ||
| resultStatus = vmv1beta1.UpdateStatusFailed | ||
| resultErr = err | ||
| } | ||
| resultErr = err |
Collaborator
There was a problem hiding this comment.
Suggested change
| resultErr = err | |
| resultStatus := vmv1beta1.UpdateStatusFailed | |
| if reconcile.IsRetryable(err) { | |
| resultStatus = vmv1beta1.UpdateStatusExpanding | |
| } | |
| resultErr = err |
Collaborator
There was a problem hiding this comment.
I'll fix it in a follow-up PR - https://github.com/VictoriaMetrics/operator/pull/2140/commits
Signed-off-by: Vadim Rutkovsky <vadim@vrutkovs.eu>
vrutkovs
approved these changes
May 11, 2026
Signed-off-by: Vadim Rutkovsky <vadim@vrutkovs.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Always propagate reconcile errors from
reconcileAndTrackStatusso the controller requeues and resources don’t get stuck in Expanding. SetresultErrfor both Expanding and Failed outcomes, update tests to expect errors in retryable paths (conflict, wait interrupted/PVC resize), and add avmoperatorchangelog entry.Written for commit 9741a7e. Summary will update on new commits.