app/vlstorage: extend top-N optimization to support sort_direction=asc#1355
Open
cuongleqq wants to merge 6 commits into
Open
app/vlstorage: extend top-N optimization to support sort_direction=asc#1355cuongleqq wants to merge 6 commits into
cuongleqq wants to merge 6 commits into
Conversation
func25
reviewed
Apr 30, 2026
func25
reviewed
Apr 30, 2026
Contributor
Author
|
@func25 thanks for the comments. I changed the asc and desc struct to 2 helpers. I think it simplifies the code flow. I also changed everything "last n" to "time sorted n results". I actually struggle with the naming for this, but I don't have a better name 🙃. |
acade6a to
2c87bfc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds
sort_directionquery arg to/select/logsql/query. Whenlimit=Nis specified, passingsort_direction=ascreturns the N oldest matching log entries.Before,
limit=Nalways used a binary-search optimization on the time range to efficiently return the last N logs without a full scan. This PR generalizes that optimization to support both directions.lastN, totimeSortedN, to mean "both directions"timeSortedRangeOpsto generalize the operation on the time rangeisDescaround to specify the sort directionsCloses #924