lib/logstorage: fix week_range[Sun,Sun] not matching rows on Sunday in filter pipe#1336
Open
cuongleqq wants to merge 2 commits into
Open
lib/logstorage: fix week_range[Sun,Sun] not matching rows on Sunday in filter pipe#1336cuongleqq wants to merge 2 commits into
cuongleqq wants to merge 2 commits into
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
vadimalekseev
approved these changes
Apr 20, 2026
Member
vadimalekseev
left a comment
vadimalekseev
left a comment
There was a problem hiding this comment.
LGTM!
Note to core contributors: I think it would be beneficial for all unit filter tests if testFilterMatchForStorage verified that any data searched via applyToBlockSearch is also matched by applyToBlockResult. If this functionality were implemented, the test would have caught this.
Signed-off-by: Cuong Le <cuongleqq@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the weekday range check for
week_rangein thefilterpipe path which uses blockResult.The old code set the bitmap to 0 if
endDay < Mondaywhich missed the case of[Sun,Sun]. So I fixed the condition toendDay < Sunday.Fixes #1335