Skip to content

feature: add per column searching to tables#386

Merged
b-rowan merged 4 commits into
masterfrom
table-search-updates
Oct 29, 2025
Merged

feature: add per column searching to tables#386
b-rowan merged 4 commits into
masterfrom
table-search-updates

Conversation

@b-rowan
Copy link
Copy Markdown
Member

@b-rowan b-rowan commented Oct 22, 2025

Adds per column searching to the tables, allowing for much better filtering.

@b-rowan b-rowan requested a review from easybe October 22, 2025 15:35
@b-rowan
Copy link
Copy Markdown
Member Author

b-rowan commented Oct 22, 2025

WIP to get a quick review/sanity check on this before I do it for the rest of the tables, only done for the devices table right now.

Also considering removing the regular search bar in favor of these, only downside is that its a bit tougher to use on mobile.

@b-rowan b-rowan force-pushed the table-search-updates branch from 528b424 to 3a69405 Compare October 23, 2025 14:23
@b-rowan b-rowan marked this pull request as ready for review October 28, 2025 14:47
@b-rowan b-rowan requested a review from jameshilliard October 29, 2025 15:29
@b-rowan b-rowan force-pushed the table-search-updates branch from d267f26 to c0fe746 Compare October 29, 2025 15:39
This is to prevent conflicts when POSTing from the datatables to request specific searches.

POST should now be used for requesting information, such as for the datatables or login credentials, while PUT should now be used for resource creation.
@b-rowan b-rowan force-pushed the table-search-updates branch from c0fe746 to 599bf7d Compare October 29, 2025 22:09
@b-rowan b-rowan merged commit b41c165 into master Oct 29, 2025
9 checks passed
@b-rowan b-rowan deleted the table-search-updates branch October 29, 2025 22:17
@easybe
Copy link
Copy Markdown
Collaborator

easybe commented Oct 30, 2025

Sorry for the late feedback, I am still on vacation.

Unfortunately, I must say, I am not a fan. I find the tables look quite ugly now. More importantly, as you noted correctly, on mobile the new search fields are quite unusable.

I would rather look into extending the main search field to support tags like e.g. GitHub's search does. So, e.g. to search only the versions one would have to specify version:1.2.3.

Of course, I have no idea how hard that is, but, I believe it would drastically improve the user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants