Closed
Conversation
Uses rule set @commitlint/config-conventional to follow: https://www.conventionalcommits.org/en/v1.0.0/
Member
|
Looked at the spec, seems like a good change 👍 |
Collaborator
|
I am not a fan. I don't see the point in using semantic commit messages unless you deduce versions from them. As previously stated, I like the style used by projects like the Linux kernel or Git itself (https://cbea.ms/git-commit/). Look at the format used by Git for e.g. revert commits, why fight the tool on that? |
Collaborator
Author
|
So let's stick to what we have. Closing PR and will close #110 as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
commitlintas proposed in #110.Opted to use rule set "@commitlint/config-conventional". This should implement (in my understanding) https://www.conventionalcommits.org/en/v1.0.0/ .
Note: this differs to our previous rules in the following way
typeprefix@easybe what do you think of https://www.conventionalcommits.org