Skip to content

Add commitlint to check commit messages#292

Closed
tsagadar wants to merge 1 commit intomasterfrom
mm/conventional-commits
Closed

Add commitlint to check commit messages#292
tsagadar wants to merge 1 commit intomasterfrom
mm/conventional-commits

Conversation

@tsagadar
Copy link
Copy Markdown
Collaborator

Implements commitlint as proposed in #110.

Opted to use rule set "@commitlint/config-conventional". This should implement (in my understanding) https://www.conventionalcommits.org/en/v1.0.0/ .

Note: this differs to our previous rules in the following way

  1. Mandates to use a type prefix
  2. Mandates to write lower-case description

@easybe what do you think of https://www.conventionalcommits.org

@b-rowan
Copy link
Copy Markdown
Member

b-rowan commented Apr 21, 2025

Looked at the spec, seems like a good change 👍

@easybe
Copy link
Copy Markdown
Collaborator

easybe commented Apr 21, 2025

I am not a fan. I don't see the point in using semantic commit messages unless you deduce versions from them. As previously stated, I like the style used by projects like the Linux kernel or Git itself (https://cbea.ms/git-commit/). Look at the format used by Git for e.g. revert commits, why fight the tool on that?

@tsagadar
Copy link
Copy Markdown
Collaborator Author

So let's stick to what we have. Closing PR and will close #110 as well.

@tsagadar tsagadar closed this Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants