fix antminers with vnish firmware sometimes not bieng detected#423
Open
bugy855 wants to merge 2 commits intoUpstreamData:masterfrom
Open
fix antminers with vnish firmware sometimes not bieng detected#423bugy855 wants to merge 2 commits intoUpstreamData:masterfrom
bugy855 wants to merge 2 commits intoUpstreamData:masterfrom
Conversation
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that some vnish antminers were not reporting data, specifically on version 1.3.0-alpha, the "version" command was not returning data, and "dev details" did not include vnish in the response, so we could not decipher that it was a vnish miner in get miner type. So, solve this ive added the "stats" command that does include vnish as well as moved the vnish check before the Antminer check, as the switch was picking up Antminer before vnish. This change also covers fixing autotune preset responses coming in different formats than expected.