Support one-file open_dataset#1479
Open
rajeeja wants to merge 11 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for opening combined grid-and-data files via a single-argument ux.open_dataset(file) call, aligning with Issue #345’s request to handle datasets stored in one file.
Changes:
- Made
filename_or_objoptional inuxarray.core.api.open_dataset, defaulting to the grid file path when omitted. - Updated
open_datasetdocstring to document and exemplify the one-file usage. - Added a unit test covering the new one-argument
open_datasetbehavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
uxarray/core/api.py |
Makes filename_or_obj optional and adds logic/docs for single-file grid+data opening. |
test/core/test_api.py |
Adds a regression test for calling ux.open_dataset() with a single argument. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
erogluorhan
reviewed
Apr 1, 2026
Member
erogluorhan
left a comment
erogluorhan
left a comment
There was a problem hiding this comment.
Thanks a lot for taking this one. Please find my comments below
…to rajeeja/onefile_open_dataset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #345 by allowing ux.open_dataset(file) for combined grid-and-data files.