Merged
Conversation
…goricalDtype instead of object dtype
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes ValueError: could not convert string to float when training classifiers with categorical columns that use pandas StringDtype, CategoricalDtype, or ArrowDtype instead of legacy object dtype
Replaces brittle dtype == "object" checks in create_column_transformer and FeatureColumnTransformer.fit with an exclusion-based helper _is_string_like_column that is robust to future pandas dtype changes
Adds tests for StringDtype and CategoricalDtype columns
Test plan
[x] Existing classifier tests pass
[x] New test_string_dtype_columns passes
[x] New test_categorical_dtype_columns passes
[x] Pre-commit hooks pass