Conversation
- Separate services and subgroups into distinct keys in the transfer model's internal dict to prevent subgroup names leaking into error messages. - Return 0.0 with a warning for unknown services instead of - raising. - Shorten warn_specialty_mismatch to report counts only.
Collaborator
Author
|
Closes #147 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"services"/"subgroups") in the transfer model's internal dict, so subgroup names (e.g.paediatric,adult_male_young) no longer appear alongside real services in error messages0.0with a warning whenget_transfer_probis called with a service not in the training set, instead of crashing with aValueErrorthat dumps hundreds of service nameswarn_specialty_mismatchmessages to report counts only, without listing every mismatched specialtytox -e docs(pinned to@3.1.0) so generated notebook markdown matches the pre-commit hook and doesn't create spurious diffsTest plan
0.0with warninguv run tox -e docsfollowed by pre-commit produces no changes