Fix stale prerequisite validation when switching from Docker to Podman

[Iamliuxiaozhen]

Summary

This fixes a setup wizard bug where the Next button could remain enabled after switching the container runtime from Docker to Podman, even though Podman prerequisites had not been validated yet.

What changed

• replaced the async computed containerSpecs state with an explicit watch on containerRuntime
• clear the previous runtime's prerequisite state immediately when the runtime changes
• added a request id guard so outdated async checks cannot overwrite the latest runtime state

Why

The previous implementation could briefly reuse the old runtime's successful prerequisite result while the new runtime check was still in flight. That allowed users to continue with stale validation state.

Testing

• switched between Docker and Podman in the setup prerequisites step
• confirmed the Next button is disabled immediately after switching runtimes
• confirmed the button only becomes enabled again after the current runtime's prerequisites pass

Related

• Closes [Bug] You can still continue switching from Docker to Podman even if the conditions are not met. #756

[Iamliuxiaozhen]

Good catch, that was my mistake. I removed the import while replacing the async prerequisite check for containerSpecs, but computedAsync is still used below for the install folder validations. I’ve added the import back in 8023b98.

[waffles-dev]

Good catch, that was my mistake. I removed the import while replacing the async prerequisite check for containerSpecs, but computedAsync is still used below for the install folder validations. I’ve added the import back in 8023b98.

Please restore it to the original line so there's no diff, thanks :)

[TibixDev]

Assuming computedAsync is what breaks here for some reason, wouldn't it be easier to have a simple watch that directly reassigns containerSpecs? The operation isn't heavy enough to require the duplication check (or if it is, let me know), so we can avoid having a request counter and all that stuff.

Shouldn't it be like two lines that way? Just reassign as ref as you did and use an immediate watcher on the runtime.

Let me know. 😄

[TibixDev]

Oh and additionally, if it does take a longer time, we can have some boolean ref such as checkingPrerequisites that'd turn false/true before and after the check, and conditionally disable the button with <existing> || checkingPrerequisites

[Iamliuxiaozhen]

Thanks, updated this to immediately mark prerequisites as checking from the runtime picker change handler, clear the previous specs synchronously, and disable Next while the current runtime checks are running. I also simplified the watcher and removed the request counter.

[waffles-dev]

Thanks, updated this to immediately mark prerequisites as checking from the runtime picker change handler, clear the previous specs synchronously, and disable Next while the current runtime checks are running. I also simplified the watcher and removed the request counter.

I can still click fast enough after selecting Podman in the drop down that it lets me through when it shouldn't.

[Iamliuxiaozhen]

Thanks for re-testing. I moved the guard earlier than the x-select change event by marking prerequisites as checking from the runtime menu item interaction itself (pointerdown, Enter, and click). I also changed the Next button click handler to re-check the prerequisite state before advancing, so even if the disabled state has not visually updated yet, the click path should no longer let the wizard through.

[waffles-dev]

Thanks for re-testing. I moved the guard earlier than the x-select change event by marking prerequisites as checking from the runtime menu item interaction itself (pointerdown, Enter, and click). I also changed the Next button click handler to re-check the prerequisite state before advancing, so even if the disabled state has not visually updated yet, the click path should no longer let the wizard through.

Thanks. It's working well for me. Bear with us - we'll get it reviewed eventually :)