Adjust some scopes in Sublime Syntax Definitions#433
Open
deathaxe wants to merge 4 commits into
Open
Conversation
This commit assigns a unique scope to context name references (e.g. includes) to distinguish them from branch-point references and normal variables.
This commit scopes global variables `variable.other.constant` so all variables are scoped with a 3rd-level scope. `.constant` is chosen as it is a default one and global variables are read-only.
This commit scopes context names `entity.name.class.context` to align kind icon in 'Goto Symbol' quick panel with that from completion popup. Completions' KIND_ID is adjusted to ensure both panels display `c` with same color. Note: Choosing a right scope is the only way to adjust the kind icon.
This commit replaces `keyword.other.variable` by `meta.interpolation`
as it is the more appropriate scope for `{{...}}` expressions,
with regards to various template languages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes to...
introduce unique scopes for context, branch_point and global variables.
variable.other.branch_point- branch point referencesvariable.other.constant- global variablesvariable.other.context- context namesGoal: Plugins, snippets and completions should be able to address all of them easily.
scopes
{{...}}expressionsmeta.interpolationinstead ofkeyword.other.variable.change scope of context name from
entity.name.functiontoentity.name.classto ensure Goto Symbol quick panel displays
ckind icon, as auto-completion popup does.The completion items' kind icon is changed to use KIND_ID_TYPE, to ensure both,
Goto Symbol quick panel and auto-completion popup display
cwith same color.Goal: Better visual consistency.