Skip to content

fix: add path overlaps in manta-up svg#10

Merged
JoshuaKGoldberg merged 3 commits intoSquiggleTools:mainfrom
Yonava:main
Apr 1, 2025
Merged

fix: add path overlaps in manta-up svg#10
JoshuaKGoldberg merged 3 commits intoSquiggleTools:mainfrom
Yonava:main

Conversation

@Yonava
Copy link
Copy Markdown
Contributor

@Yonava Yonava commented Mar 16, 2025 •
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

Fixed the manta-up svg in order to reduce the graininess issue on rendering (in some browsers on some machines).

I wasn't able to reproduce the issue on chrome, firefox or safari on my machine but thanks to the diligence of @teykamp he was able to straighten things out a bit

🦦

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
squiggleconf2025 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 6:37pm

@teykamp
Copy link
Copy Markdown
Contributor

teykamp commented Mar 16, 2025

Issue was that the first path and third path inside of the manta-up svg were not overlapping, causing the line near the border of the manta body. The implemented fix was to change the stroke width from 0 to 1 causing the two paths to overlap enough to reduce the artifact.

@JoshuaKGoldberg
Copy link
Copy Markdown
Member

JoshuaKGoldberg commented Apr 1, 2025

Oh! Sorry, I didn't realized I hadn't watched all activity in this repo, and missed this. Reviewing now!

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Apr 1, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I can confirm this fixes it for me on Firefox. Nice work, thank you!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 0210d3e into SquiggleTools:main Apr 1, 2025
9 checks passed
@JoshuaKGoldberg
Copy link
Copy Markdown
Member

JoshuaKGoldberg commented Apr 1, 2025

@all-contributors please add @Yonava for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors Bot mentioned this pull request Apr 1, 2025
Merged
@allcontributors
Copy link
Copy Markdown
Contributor

allcontributors Bot commented Apr 1, 2025

@JoshuaKGoldberg

I've put up a pull request to add @Yonava! 🎉

JoshuaKGoldberg pushed a commit that referenced this pull request Apr 1, 2025
@allcontributors
docs: add yonava as a contributor for code (#12)
2609186 
Adds @Yonava as a contributor for code.

This was requested by JoshuaKGoldberg [in this
comment](#10 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 Bug: Aliasing on manta rays in the registration section

3 participants

@Yonava @teykamp @JoshuaKGoldberg