Skip to content

BUILD-11264 chore: upgrade gh-action_release to v7 (master)#108

Merged
julien-carsique-sonarsource merged 2 commits intomasterfrom
feature/BUILD-11249-upgrade-gh-action-release-v7
May 6, 2026
Merged

BUILD-11264 chore: upgrade gh-action_release to v7 (master)#108
julien-carsique-sonarsource merged 2 commits intomasterfrom
feature/BUILD-11249-upgrade-gh-action-release-v7

Conversation

@julien-carsique-sonarsource
Copy link
Copy Markdown
Contributor

Part of BUILD-11249.

Changes

  • Migrate trigger from release: published to workflow_dispatch with version input
  • Upgrade gh-action_release reference to @master (v7 dogfood)
  • Add isDummyProject: true

Copilot AI review requested due to automatic review settings May 6, 2026 09:30
@julien-carsique-sonarsource julien-carsique-sonarsource requested a review from a team as a code owner May 6, 2026 09:30
@sonar-review-alpha
Copy link
Copy Markdown

sonar-review-alpha Bot commented May 6, 2026

Summary

This PR migrates the release workflow from automatic (GitHub release event) to manual (workflow_dispatch), allowing explicit control over version and PyPI destination. It upgrades gh-action_release to @master (v7 in development) and marks this as a dummy project for testing the new action version. This represents a shift from passive to active release triggering, where the version must be explicitly provided as an input rather than derived from the release event.

Key behavioral changes:

  • Release no longer auto-triggers on publishing a GitHub release
  • version is now a required manual input
  • Test PyPI publishing is now explicitly opted-in (defaults to false) rather than inferred from prerelease status
  • The action reference changed from stable v6 to the development master branch

What reviewers should know

Start here: Review the trigger change in lines 2-13. The workflow now requires manual invocation with explicit version input instead of auto-triggering on release events.

Key decision: The @master reference (line 23, dogfood comment) means this PR is testing an unreleased version of gh-action_release — this is intentional for validating v7 before general availability.

Watch for: The logic inversion on line 25 — publishToPyPI now uses !inputs.publishToTestPyPI (publish to production when NOT publishing to test), which is clearer than the previous prerelease-based logic but represents a semantic shift in how test releases are controlled.

Testing context: isDummyProject: true (line 27) is already present and indicates this is a low-risk test case. Verify the manual inputs work as expected in the workflow dispatch UI before deploying to production workflows.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title chore: upgrade gh-action_release to v7 (master) BUILD-11264 chore: upgrade gh-action_release to v7 (master) May 6, 2026
@hashicorp-vault-sonar-prod
Copy link
Copy Markdown

hashicorp-vault-sonar-prod Bot commented May 6, 2026

BUILD-11264

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s release workflow to use a manual workflow_dispatch trigger with an explicit version input, while dogfooding SonarSource/gh-action_release v7 via @master and passing isDummyProject: true.

Changes:

  • Switch release trigger from release: published to workflow_dispatch with a required version input.
  • Update the reusable workflow reference from gh-action_release@v6 to @master (v7 dogfood).
  • Adjust release inputs to pass version and always publish to PyPI while skipping Python releasability checks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/release.yml
Comment thread .github/workflows/release.yml
sonar-review-alpha[bot]

This comment was marked as resolved.

@julien-carsique-sonarsource julien-carsique-sonarsource enabled auto-merge (rebase) May 6, 2026 09:46
sonar-review-alpha[bot]

This comment was marked as outdated.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

🗣️ Give feedback

@julien-carsique-sonarsource julien-carsique-sonarsource merged commit 9ab9638 into master May 6, 2026
13 checks passed
@julien-carsique-sonarsource julien-carsique-sonarsource deleted the feature/BUILD-11249-upgrade-gh-action-release-v7 branch May 6, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants