Skip to content

ECHOES-1262 Wrap page footer elements#686

Draft
david-cho-lerat-sonarsource wants to merge 1 commit into
mainfrom
david/ECHOES-1262-wrap-page-footer-elements
Draft

ECHOES-1262 Wrap page footer elements#686
david-cho-lerat-sonarsource wants to merge 1 commit into
mainfrom
david/ECHOES-1262-wrap-page-footer-elements

Conversation

@david-cho-lerat-sonarsource
Copy link
Copy Markdown
Contributor

No description provided.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 11, 2026

Deploy Preview for echoes-react ready!

Name Link
🔨 Latest commit 407a8c6
🔍 Latest deploy log https://app.netlify.com/projects/echoes-react/deploys/6a0194255686470008f804fc
😎 Deploy Preview https://deploy-preview-686--echoes-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@david-cho-lerat-sonarsource david-cho-lerat-sonarsource marked this pull request as draft May 11, 2026 08:17
@hashicorp-vault-sonar-prod
Copy link
Copy Markdown

hashicorp-vault-sonar-prod Bot commented May 11, 2026

ECHOES-1262

@sonar-review-alpha
Copy link
Copy Markdown

sonar-review-alpha Bot commented May 11, 2026

Summary

This PR enables responsive wrapping for the page footer. Previously, footer elements were constrained to a single line with justify-content: space-between. The change adds flex-wrap: wrap so elements can wrap on smaller viewports, and introduces a gap property using design tokens (200px vertical, 300px horizontal) to maintain consistent spacing between wrapped elements.

File changed: src/components/layout/LayoutSlots.tsx (PageFooter component only)

What reviewers should know

Where to look:

  • Single change in the PageFooter styled component (lines 147-151)

What to verify:

  • Check footer behavior on narrow viewports/mobile to confirm elements wrap appropriately
  • Verify the gap spacing looks balanced when elements wrap (vertical vs horizontal gaps)
  • Ensure justify-content: space-between combined with wrapping still produces desired alignment when elements are on separate lines

Context:

  • Uses existing design tokens (dimension-space-200, dimension-space-300) for consistency
  • Minimal change with no component logic or prop changes

  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

Clean, minimal change with no issues. The gap values (dimension-space-200 row / dimension-space-300 column) mirror the asymmetric padding already on the component, and the justify-content: space-between + flex-wrap combination behaves correctly: when the footer narrows and the two items (copyright text + links group) can't fit on one line, they stack to separate rows and both align left — a standard, expected responsive footer pattern.

🗣️ Give feedback

@david-cho-lerat-sonarsource david-cho-lerat-sonarsource force-pushed the david/ECHOES-1262-wrap-page-footer-elements branch from b868506 to 407a8c6 Compare May 11, 2026 08:32
@sonarqube-next
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant