fix: guard against undefined error in yargs fail callback#835
Open
monitoring-smartthings wants to merge 2 commits into
Open
Conversation
Running `smartthings` or `smartthings -h` without a subcommand crashed with a TypeError instead of showing usage help. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 5c9021f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Running
smartthingsorsmartthings -hwithout a subcommand crashes with aTypeErrorinstead of showing usage help:Yargs calls the
.fail()callback with(message, undefined, yargs)when a validation failure is not caused by a thrown error (e.g. no subcommand provided, triggering.demandCommand()). Theinoperator throws aTypeErrorwhen its right-hand operand isundefined.Fix: add a null-guard (
error &&) before theincheck soundefinedfalls through to theelsebranch, which correctly prints the yargs-generated message and help text.Test plan
smartthingswith no arguments — should print usage/help instead of crashingsmartthings -h— should print help instead of crashingerror.message🤖 Generated with Claude Code