Fix handling for cameras without per-zone sensitivity handling#2965
Open
ctowns wants to merge 1 commit into
Open
Fix handling for cameras without per-zone sensitivity handling#2965ctowns wants to merge 1 commit into
ctowns wants to merge 1 commit into
Conversation
|
Invitation URL: |
Test Results 72 files 508 suites 0s ⏱️ For more details on these failures, see this check. Results for commit 797f7cc. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 797f7cc |
nickolas-deboom
approved these changes
May 12, 2026
hcarter-775
approved these changes
May 13, 2026
| max_duration = cmd.args.maxDuration, | ||
| blind_duration = cmd.args.blindDuration, | ||
| sensitivity = cmd.args.sensitivity | ||
| sensitivity = per_zone_sensitivity_supported and cmd.args.sensitivity or nil -- omit even if provide by client if per-zone sensitivity is not supported |
Contributor
There was a problem hiding this comment.
Suggested change
| sensitivity = per_zone_sensitivity_supported and cmd.args.sensitivity or nil -- omit even if provide by client if per-zone sensitivity is not supported | |
| sensitivity = per_zone_sensitivity_supported and cmd.args.sensitivity or nil -- omit even if provided by client if per-zone sensitivity is not supported |
nit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a couple issues related to cameras that do not support per-zone sensitivity:
Type of Change
Checklist
Description of Change
Summary of Completed Tests