WWSTCERT-10832 - add aeotec 8 series new#2897
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
Test Results 72 files 511 suites 0s ⏱️ For more details on these errors, see this check. Results for commit a01294e. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against a01294e |
|
Invitation URL: |
| MATCHING_MATRIX = { | ||
| mfrs = 0x0371, | ||
| product_types = {0x0002, 0x0102, 0x0202}, | ||
| product_ids = 0x0018 |
There was a problem hiding this comment.
This is different than what is in the fingerprint. Please double check the product ids for all devices.
| preferenceType: integer | ||
| definition: | ||
| minimum: 0 | ||
| maximum: 2678400 |
There was a problem hiding this comment.
This is higher than what the preference allows. Check the parameter definitions in preferences.lua and change the size to what it should be or update this to match the size of parameter 1.
| end | ||
|
|
||
| local function do_refresh(driver, device) | ||
| device:send(Battery:Get({})) |
There was a problem hiding this comment.
Why not use the default functionality for refresh? This will also read state from the command classes that support the devices capabilities rather than just battery.
| default: 0 | ||
| - name: "parameter13" | ||
| title: "13 Mold alarm offset" | ||
| desccription: "Increase the humidity threshold." |
There was a problem hiding this comment.
| desccription: "Increase the humidity threshold." | |
| description: "Increase the humidity threshold." |
| default: 0 | ||
| - name: "parameter13" | ||
| title: "13 Mold alarm offset" | ||
| desccription: "Increase the humidity threshold." |
There was a problem hiding this comment.
| desccription: "Increase the humidity threshold." | |
| description: "Increase the humidity threshold." |
There was a problem hiding this comment.
This file has bytes on the end of the name that make it hidden to require. It is likely the main cause of the widespread test failures
| device:send(Battery:Get({})) | ||
|
|
||
| device:register_native_capability_attr_handler("temperatureMeasurement", "temperature") | ||
| -- device:register_native_capability_attr_handler("colorControl", "hue") |
There was a problem hiding this comment.
Remove commented out code.
| can_handle = can_handle_aeotec_aerq | ||
| } | ||
|
|
||
| return aeotec_aerq_8 No newline at end of file |
There was a problem hiding this comment.
Add newline to end of this file and any other files that have it missing.
There was a problem hiding this comment.
This subdriver is unnecessary. The aeotec-door-window-sensor-8 handlers cover everything here. Remove this driver, and have the device be handled by that one.
|
I will re-review once the tests are passing. Ill also request that you test your device on a real hub to ensure its functionality is what you expect. |
KKlimczukS
changed the title
There was a problem hiding this comment.
This file must also have a weird name
|
@iot-holding once you resolve the branch conflicts and ensure the tests are passing, we can re-review this PR. |
|
@cjswedes @aleclorimer could you re-review this? |
There was a problem hiding this comment.
This can handle never returns true and no longer loads the sub_driver when returning.
aleclorimer
left a comment
aleclorimer
left a comment
There was a problem hiding this comment.
Look like a couple of @cjswedes comments were still not addressed and a lot of driver tests are broken.
5 participants
Check all that apply
Type of Change
Checklist
Description of Change
This is a new clean pull request for the new Aeotec Series 8 devices.
Summary of Completed Tests