Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@ripple-ts/adapter
@ripple-ts/adapter-bun
@ripple-ts/adapter-node
@ripple-ts/cli
create-ripple
@ripple-ts/eslint-parser
@ripple-ts/eslint-plugin
@ripple-ts/prettier-plugin
ripple
@ripple-ts/rollup-plugin
@ripple-ts/typescript-plugin
@ripple-ts/vite-plugin
commit: |
…eanup The nulling chain in destroy_block set block.d to null twice: block.fn = block.s = block.d = block.p = block.d = block.co = block.t = null The second block.d = null is a duplicate. Removing it so each property in the chain is unique, preventing potential confusion about which property the second slot was intended to clear.
anubra266
force-pushed
the
fix/blocks-destroy-block-duplicate-null
branch
from
ae8d641 to
43ee201
Compare
trueadm
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
block.d = nullfrom the nulling chain indestroy_blockblock.fn = block.s = block.d = block.p = block.d = block.co = block.t = null—block.dappeared twiceblock.fn = block.s = block.d = block.p = block.co = block.t = nullCloses #795
Note
Low Risk
Trivial cleanup-only change in a teardown path; behavior should be unchanged aside from eliminating redundant assignment.
Overview
Fixes
destroy_blockcleanup inblocks.jsby removing a duplicatedblock.d = nullin the property-nulling assignment chain after teardown/unlink, without changing destruction behavior otherwise.Written by Cursor Bugbot for commit 43ee201. This will update automatically on new commits. Configure here.