fix(runtime): increment flush_count to activate infinite-loop circuit breaker#794
Merged
fix(runtime): increment flush_count to activate infinite-loop circuit breaker#794
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@ripple-ts/adapter
@ripple-ts/adapter-bun
@ripple-ts/adapter-node
@ripple-ts/cli
create-ripple
@ripple-ts/eslint-parser
@ripple-ts/eslint-plugin
@ripple-ts/prettier-plugin
ripple
@ripple-ts/rollup-plugin
@ripple-ts/typescript-plugin
@ripple-ts/vite-plugin
commit: |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
…cuit breaker flush_count was declared and checked (> 1001) and reset, but never incremented. The infinite reactive update loop guard was effectively dead code — a cycle where a reactive update triggers another update would run forever without being caught. Adding flush_count++ before the guard check activates the circuit breaker as intended.
anubra266
force-pushed
the
fix/runtime-flush-count-increment
branch
from
e34092b to
c64b453
Compare
…ermanent lockout After the circuit breaker triggered (flush_count > 1001), the early return skipped the flush_count = 0 reset below, leaving flush_count permanently above 1001. Every subsequent flush_microtasks call — even from legitimate non-circular reactive updates — would immediately return without processing, permanently breaking reactivity. Reset flush_count before returning so the system recovers after an infinite-loop is aborted.
trueadm
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flush_count++inflush_microtasksbefore the> 1001guard checkflush_countwas declared, checked, and reset but never incremented — making the infinite reactive update loop protection completely inoperativeCloses #793
Note
Medium Risk
Touches core runtime scheduling/flush behavior; while the change is tiny, it can alter how extreme reactive-update loops are handled and could mask issues by early-bailing.
Overview
Ensures the reactive update infinite-loop circuit breaker in
flush_microtasksactually triggers by incrementingflush_counton each flush and resetting it when the guard trips.This prevents unbounded microtask-driven update cycles from hanging the browser by bailing out after the threshold is exceeded.
Written by Cursor Bugbot for commit cce985b. This will update automatically on new commits. Configure here.