Skip to content

Preview PRs in playground#116

Merged
leonidaz merged 1 commit intoRipple-TS:mainfrom
hatemhosny:preview-in-livecodes
Sep 10, 2025
Merged

Preview PRs in playground#116
leonidaz merged 1 commit intoRipple-TS:mainfrom
hatemhosny:preview-in-livecodes

Conversation

@hatemhosny
Copy link
Copy Markdown
Collaborator

@hatemhosny hatemhosny commented Sep 9, 2025

This PR adds github actions to preview PR changes in playground. See Preview in LiveCodes.

It uses pkg.pr.new to load Ripple compiler, runtime and formatter so that they can be tried in the playground before merge.

Example: hatemhosny/racing-bars#211 (comment)

image

Please note:

  • The GH actions need to be merged to the main branch to work (details).
  • This needs the pkg.pr.new packages to be available.

@hatemhosny hatemhosny mentioned this pull request Sep 10, 2025
8 tasks
@leonidaz
Copy link
Copy Markdown
Collaborator

thank you!

let's merge and see

@leonidaz leonidaz merged commit cba86f4 into Ripple-TS:main Sep 10, 2025
10 of 11 checks passed
@hatemhosny
Copy link
Copy Markdown
Collaborator Author

@leonidaz
So, it did post the comment with a link to playground: #122 (comment)

However, the files were not loaded in the playground because pkg.pr.new workflow did not publish the packages, because of lack of collaborator approval:
PR is approved by collaborator: false

@leonidaz
Copy link
Copy Markdown
Collaborator

@hatemhosny it's because from non-contributors it requires a manual approval to run. Could your job depend on pkg.pr run so then they're synced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants