Don't buffer files in memory at send time#260
Merged
PaulSonOfLars merged 5 commits intov2from Mar 21, 2026
Merged
Conversation
|
Hi @PaulSonOfLars, Tested PR #260 with a 31 MB file upload - works perfectly! 🎉 Results Before: ~66 MB peak (buffered entire file) File: 31 MB Thank you for the quick fix! 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Addresses #259
Previously, we would pipe files while creating the multipart reader.
This changed in #242, where i opted to avoid double-marshalling fields - but introduced a regression where files were double-buffered in memory in an attempt to maintain the fix from #231.
This PR introduces regression tests to cover those edge cases, and then updates the requests code to correctly use pipes and allow retries without double-buffering files.
Impact