SaiSandeep - Fix "No comparison" filter options failing in Total Org Summary Dashboard #5278
Open
saisandeepkoritala wants to merge 2 commits into
Open
SaiSandeep - Fix "No comparison" filter options failing in Total Org Summary Dashboard #5278saisandeepkoritala wants to merge 2 commits into
saisandeepkoritala wants to merge 2 commits into
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When users try to filter stats and compare them by week by week or month by month or year by year by selecting one of the options in dropdown , we get an blank page with error details.
Fix
Ensured the data passed onto the children component is rendered properly by handling all edge cases and made sure the code is reusable by extracting some portion of code into a function.
Related PRS :
Not Related to any other PR's
Main changes explained:
Made sure the data is rendered properly in children component
How to test:
npm installandnpm startto run this PR locallyScreenshots or videos of changes: