Sayali: add onMouseDown preventDefault to fix Firefox timer button double-click bug#5275
Open
sayali-2308 wants to merge 1 commit into
Open
Sayali: add onMouseDown preventDefault to fix Firefox timer button double-click bug#5275sayali-2308 wants to merge 1 commit into
sayali-2308 wants to merge 1 commit into
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
sayali-2308
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs (if any):
None — frontend only change.
Main changes explained:
src/components/Timer/Countdown.jsxto addonMouseDown={e => e.preventDefault()}to the pause and resume/play buttons inside the circular countdown timer to fix Firefox first-click registration issueHow to test:
Sayali-Fix-Firefox-Timer-Bugnpm install && npm run start:localScreenshots or videos of changes:
Note:
Firefox has a known issue where buttons inside SVG-wrapped containers (like CircularProgressbarWithChildren) don't register onClick on the first click due to focus handling. Adding onMouseDown with preventDefault fixes this without affecting other browsers.