fix(donut-chart): add externalLabelGuidesPlugin to make percentages visible#5273
Open
somramnani wants to merge 1 commit into
Open
fix(donut-chart): add externalLabelGuidesPlugin to make percentages visible#5273somramnani wants to merge 1 commit into
somramnani wants to merge 1 commit into
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
somramnani
added
the
do not review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related PRS (if any):
This frontend PR is related to the #XXX backend PR.
Main changes explained:
DonutChart.jsxto follow the Volunteer Status chart pattern by disabling crowded in-slice datalabels and using the shared external label guide plugin to display values and percentages outside the donut chart.DonutChart.jsxto also show each category’s value and percentage in the legend, so the breakdown remains visible even if external chart labels are hard to read.DonutChart.module.cssto give the donut chart more space for external labels and improve spacing between the chart and legend.How to test:
npm installand...to run this PR locally/totalorgsummaryScreenshots or videos of changes: