Sayali: add projectHistory tracking and getAllTimeprojectMembership endpoint#2225
Open
sayali-2308 wants to merge 1 commit into
Open
Sayali: add projectHistory tracking and getAllTimeprojectMembership endpoint#2225sayali-2308 wants to merge 1 commit into
sayali-2308 wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Fixes #1 (Priority Medium) - Fix the Projects Report incomplete Members list when the ALL-TIME button is selected.
Related PRs (if any):
This backend PR is related to frontend OneCommunityGlobal/HighestGoodNetworkApp#5225
To test this backend PR you need to checkout frontend branch: Sayali-Fix-AllTime-Members-ProjectReport
Main changes explained:
projectHistoryfield touserProfilemodel to track all projects a user has ever been assigned to, even after unassignmentgetAllTimeprojectMembershipendpoint (GET /api/project/:projectId/alltimeusers/) that queries users byprojectHistoryinstead ofprojectsputUserProfileinuserProfileController.jsto updateprojectHistorywhenever a user's projects changegetProjectHistoryandpostClearProjectHistoryutility functionsprojectRouter.jsanduserProfileRouter.jsgetprojectMembershipto usemongoose.Types.ObjectIdfor proper ObjectId matchingHow to test:
Sayali-Fix-AllTime-Members-Backendnpm installandnpm run buildthennpm run startSayali-Fix-AllTime-Members-ProjectReportScreenshots or videos of changes:
Note:
This PR works together with frontend OneCommunityGlobal/HighestGoodNetworkApp#5225 Both must be merged together for the fix to work.