Feature/hw health machine metadata#1671
Merged
Merged
Conversation
Contributor
|
Can you squash/resign commits. So DCO will pass and we can run tests properly |
yoks
reviewed
May 14, 2026
mkoci
force-pushed
the
feature/hw-health-machine-metadata
branch
from
06ffd6f to
9d07d4c
Compare
Contributor
|
I'm fine the changes, but before we can merge we need all your commits to have verified signatures |
mkoci
force-pushed
the
feature/hw-health-machine-metadata
branch
2 times, most recently
from
7283f8c to
8db0690
Compare
Signed-off-by: mkoci <mkoci@nvidia.com>
Signed-off-by: mkoci <mkoci@nvidia.com>
Signed-off-by: mkoci <mkoci@nvidia.com>
Signed-off-by: mkoci <mkoci@nvidia.com>
Signed-off-by: mkoci <mkoci@nvidia.com>
Signed-off-by: mkoci <mkoci@nvidia.com>
mkoci
force-pushed
the
feature/hw-health-machine-metadata
branch
from
8db0690 to
5300426
Compare
|
🌿 Preview your docs: https://nvidia-preview-pull-request-1671.docs.buildwithfern.com/infra-controller |
Contributor
Author
|
I have fixed signing key in my new dev env Also documented with an issue -> #1692 |
2 tasks
yoks
approved these changes
May 14, 2026
Coco-Ben
approved these changes
May 14, 2026
jayzhudev
pushed a commit
to jayzhudev/ncx-infra-controller-core
that referenced
this pull request
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds machine placement and NVLink metadata to the hardware health pipeline.
Type of Change
Related Issues (Optional)
Breaking Changes
Testing