Skip to content

Fix destruction order in solve.cu #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 1 commit into from
May 14, 2026
Merged

Fix destruction order in solve.cu #1216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions cpp/src/mip_heuristics/solve.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,8 +401,6 @@ mip_solution_t<i_t, f_t> solve_mip_helper(optimization_problem_t<i_t, f_t>& op_p
// Start early FJ (CPU and GPU) during presolve to find incumbents ASAP
// Only run if presolve is enabled (gives FJ time to find solutions)
// and we're not in deterministic mode
std::unique_ptr<detail::early_cpufj_t<i_t, f_t>> early_cpufj;
std::unique_ptr<detail::early_gpufj_t<i_t, f_t>> early_gpufj;

// Track best incumbent found during presolve (shared across CPU and GPU FJ).
// early_best_objective is in the original problem's solver-space (always minimization),
Expand All @@ -414,6 +412,9 @@ mip_solution_t<i_t, f_t> solve_mip_helper(optimization_problem_t<i_t, f_t>& op_p
std::vector<f_t> early_best_user_assignment;
std::mutex early_callback_mutex;

std::unique_ptr<detail::early_cpufj_t<i_t, f_t>> early_cpufj;
std::unique_ptr<detail::early_gpufj_t<i_t, f_t>> early_gpufj;

bool run_early_fj = run_presolve && settings.determinism_mode != CUOPT_MODE_DETERMINISTIC &&
op_problem.get_n_integers() > 0 && op_problem.get_n_constraints() > 0;
f_t no_bound = problem.presolve_data.objective_scaling_factor >= 0 ? (f_t)-1e20 : (f_t)1e20;
Expand Down
Loading