Add symbol visibility checks#1215
Draft
bdice wants to merge 4 commits into
Draft
Conversation
Signed-off-by: Bradley Dice <bdice@bradleydice.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Bradley Dice <bdice@bradleydice.com>
Contributor
Author
|
Update: split the visibility work from the CUDA template-stub work. Committed
Validation:
|
Signed-off-by: Bradley Dice <bdice@bradleydice.com>
Contributor
Author
|
Update: fixed the CUDA template-stub portion without including Committed
Reference pattern from rapidsai/cudf#14726: CUDA kernels should have internal/hidden linkage rather than relying on externally visible template stubs. Validation:
|
Signed-off-by: Bradley Dice <bdice@bradleydice.com>
Contributor
Author
|
Update: refactored C++ exports to namespace-level annotations in Details:
Validation after this refactor:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci/check_symbols.shexported-symbol guard modeled on cuDF, with cuOpt-specific forbidden internal namespace patterns.libcuoptconda recipe after installinglibmps_parserandlibcuopt.libcuoptC API andlibmps_parserparser/writer APIs.Status
This is intentionally opened as a draft. The new guard is useful, but
libcuopt.sostill exports CUB/Thrust/RAFT/RMM and cuOpt detail symbols after the initial hidden-visibility pass.Validation
cmake --build /home/coder/cuopt/cpp/build/latest --target mps_parser cuopt -j 8passed../ci/check_symbols.sh /home/coder/cuopt/cpp/build/latest/libmps_parser/libmps_parser.sopassed../ci/check_symbols.sh /home/coder/cuopt/cpp/build/latest/libcuopt.socurrently fails as expected; first failing pattern iscub::with 1910 matches in the rebuilt library.libcuopt.so(cuOptCreateProblem,cuOptGetFloatSize,cuOptSolve,cuOptDestroySolution).References
RMM_EXPORTrapidsai/rmm#1654.