[benchmarking] Add configurable GPU memory warning threshold#1966
Draft
rlratzel wants to merge 1 commit into
Draft
[benchmarking] Add configurable GPU memory warning threshold#1966rlratzel wants to merge 1 commit into
rlratzel wants to merge 1 commit into
Conversation
Adds `max_allowed_gpu_mem_use_warning_threshold` at session and entry level so pre-run GPU warnings only fire when memory usage exceeds a configured fraction of total GPU memory. Warnings are collected from both pre- and post-run checks and stored in `result_data["warnings"]` so sinks (e.g. SlackSink) can read them directly instead of re-deriving them from raw GPU stats. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: rlratzel <rratzel@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_allowed_gpu_mem_use_warning_thresholdat session and per-entry level so pre-run GPU warnings only fire when memory usage exceeds a configured fraction of total GPU memory (0.0-1.0)result_data["warnings"]so sinks (e.g. SlackSink) read them directly instead of re-deriving them from raw GPU statsTest plan
max_allowed_gpu_mem_use_warning_thresholdset in the session config and confirm warnings only fire when GPU usage exceeds the thresholdresult_data["warnings"]is populated and appears correctly in the Slack sink message🤖 Generated with Claude Code