Added example showing difference between Rotate and Rotating#4723
Open
GoThrones wants to merge 5 commits intoManimCommunity:mainfrom
Open
Added example showing difference between Rotate and Rotating#4723GoThrones wants to merge 5 commits intoManimCommunity:mainfrom
GoThrones wants to merge 5 commits intoManimCommunity:mainfrom
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Contributor
Author
|
The test_logging_to_file failure seems unrelated to my changes. I had modified only rotation.py, but the extra log comes from commands.py. Could a maintainer see if a re-run of CI would help ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
This PR adds an example in rotation.py file, in the Rotate class, the output of which shows the difference between Rotate and Rotating.
Motivation and Explanation: Why and how do your changes improve the library?
Just by observing the output of the examples given in Rotate and Rotating class, it wasn't clear what the difference is, between the two classes.
DifferenceBetweenRotateAndRotating.mp4
Reviewer Checklist