Custom cardinality editor#56
Merged
HansMarcus01 merged 6 commits intoLIDSOL:mainfrom Oct 8, 2025
Merged
Conversation
…lities - Add 'Custom...' option to ONE_TO_MANY cardinality dropdown - Support all three notation systems (Default, Crow's Foot, IDEF1X) - Add input validation: first coordinate (0 or 1), second coordinate (>1 or *) - Prevent negative cardinalities and enforce proper format (x,y)
- Add timestamp to undo entry messages to prevent deduplication - Ensures each custom cardinality change creates a unique undo entry
- Auto-focus input field when 'Custom...' is selected from dropdown - Add Enter key to apply custom cardinality - Add Escape key to cancel custom input
- Custom option in side bar panel - Custom option for relationship context menu
HansMarcus01
reviewed
Oct 6, 2025
HansMarcus01
left a comment
HansMarcus01
left a comment
There was a problem hiding this comment.
In the section custom, the handler allows you to enter 0005 before the cardinality value, but this ceros be has remove with press enter.
| } | ||
| DEFAULT: { value: "1,1", label: "(1,1)" }, | ||
| NULLEABLE: { value: "0,1", label: "(0,1)" }, | ||
| }; |
Author
There was a problem hiding this comment.
Whitespaces have been removed
Author
There was a problem hiding this comment.
And leading zeroes for custom cardinality are not allowed
Author
There was a problem hiding this comment.
Now leading zeroes are allowed but normalized when entered
|
This pull request resolve the issue #49 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now you can choose a custom cardinality in the one-to-many relationships