add foreign key check#10
Merged
HansMarcus01 merged 4 commits intomainfrom May 23, 2025
Merged
Conversation
pabloem
reviewed
Apr 30, 2025
pabloem
left a comment
pabloem
left a comment
There was a problem hiding this comment.
Muchas gracias! Podrias mostrar screenshots / video de como se comporta tu cambio?
| relationship_deleted: "Relationship deleted", | ||
| type_deleted: "Type deleted", | ||
| cannot_connect: "Cannot connect, the columns have different types", | ||
| cannot_fk: "Cannot create foreign key from this field", |
There was a problem hiding this comment.
podrias agregar una explicacion al mensaje? p.e. - "Only fields that are UNIQUE and ... bla bla bla"
Member
Author
There was a problem hiding this comment.
Ya agregué la explicación al mensaje
update message shown when a field cant be selected as a foreign key.
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Se añadió la funcionalidad para que solo sea posible formar una FK desde un campo válido. Este tiene que ser una llave primaria o ser único y no nulo.
Cuando se puede usar el campo como llave foránea funciona normalmente:
Cuando no es posible utilizar el campo como llave foránea se muestra un mensaje: