Fix ModalBottomSheetDialog content insets#2849
Draft
Conversation
MatkovIvan
reviewed
Mar 11, 2026
| dismissOnClickOutside = properties.shouldDismissOnClickOutside, | ||
| usePlatformDefaultWidth = false, | ||
| usePlatformInsets = false, | ||
| usePlatformInsets = true, |
There was a problem hiding this comment.
It doesn't look correct to me. The dialog itself should remain "full screen". Insets should work correctly with usePlatformInsets = false.
It seems that the fix should be on lower levels without touching material3 module
There was a problem hiding this comment.
Confirmed that it breaks basic usage even in mpp
jb-main |
#2849 |
|---|---|
 |
 |
 |
 |
MatkovIvan
suggested changes
Mar 11, 2026
| dismissOnClickOutside = properties.shouldDismissOnClickOutside, | ||
| usePlatformDefaultWidth = false, | ||
| usePlatformInsets = false, | ||
| usePlatformInsets = true, |
There was a problem hiding this comment.
Confirmed that it breaks basic usage even in mpp
jb-main |
#2849 |
|---|---|
|
|
|
|
Author
|
@MatkovIvan thanks for the example. That does not look correct. We could have some test when this behavior is not met. I will add it and investigate deeper. |
svastven
force-pushed
the
svastven/bugfix/modal-bottom-sheet-insets
branch
from
06b9a94 to
af6b6a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
ModalBottomSheetDialogcontent insets by not excluding IME insets from inner contentFixes https://youtrack.jetbrains.com/issue/CMP-9846
Testing
Add
ModalBottomSheetTesttest suiteThis should be tested by QA
Release Notes
Fixes - iOS
ModalBottomSheetDialogcontent inset calculation