Conversation
CocoChart
force-pushed
the
fix-360
branch
6 times, most recently
from
d122b87 to
7a4aec4
Compare
benel
left a comment
benel
left a comment
There was a problem hiding this comment.
Thank you @CocoChart @Engu-s @aminssutt for your contribution.
| Et une session active avec mon compte | ||
| Quand j'essaie d'ajouter une image à une glose | ||
| Alors je vois l'image "<IMAGE DESCRIPTION>" dans la glose | ||
| Et je ne vois pas le texte alternatif dans la glose |
There was a problem hiding this comment.
That should work. But maybe you could add a string parameter to tell what the hidden alternative text is supposed to be.
aminssutt
force-pushed
the
fix-360
branch
2 times, most recently
from
791c4ff to
f1e5be3
Compare
|
Hmm, the test pass although the software behavior is not fixed yet... 🤔 |
@benel The problem is that the bug only occurs when the name of the image has a special character, which means it is a specific value of the string parameter in the scenario. |
Co-authored-by: Enguerrand LUCAT <enguerrand.lucat@gmail.com> Co-authored-by: Lakhdar Berache <lakhdar.berache@utt.fr>
Co-authored-by: Enguerrand LUCAT <enguerrand.lucat@gmail.com> Co-authored-by: Corentin CHARTIER <corentinchartier334@gmail.com>
Co-authored-by: Berache Lakhdar <lakhdarberache@gmail.com> Co-authored-by: Chartier Corentin <corentinchartier334@gmail.com>
benel
left a comment
benel
left a comment
There was a problem hiding this comment.
Thank you @CocoChart @Engu-s @aminssutt for your updates.
Please have a look at the comments below.
There was a problem hiding this comment.
Hmm. By doing this you will break the figure inclusion in the README.
- You may instead copy this file with a different name.
- Moreover, I suppose there are very few people naming a file with a starting hash. You could instead use the hash a symbol for "number" (as it is done frequently in English).
Hence you should preserve docs/architecture.png and copy it as docs/architecture#1.png. OK ?
| Quand j'essaie d'ajouter une image à une glose | ||
| Alors je vois l'image "<IMAGE DESCRIPTION>" dans la glose | ||
| Quand j'essaie d'ajouter une image "#architecture.png" à une glose | ||
| Alors je vois l'image "#architecture.png" dans la glose |
There was a problem hiding this comment.
See the previous comment on a more realistic name that includes a hash.
| const arrayBuffer = reader.result; | ||
|
|
||
| fetch(`${service}/${id}/${attachment.name}`, { | ||
| fetch(`${service}/${id}/${attachment.name.split('#').join('%23')}`, { |
There was a problem hiding this comment.
split then join? Well it works, but why not simply use replaceAll?
4 participants
Co-authored-by:
Enguerrand LUCAT @Engu-s
Lakhdar Berache @aminssutt
We hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.