Add WebRTC-based chat to web#518
Conversation
|
Hell yea! Thank you @sleroq Do you want me to rebase, or do you plan to work on this more? thank you! |
|
I'll finish it up today/tomorrow. it's basically ready, just wanted to clean up the code a bit more. You can take it from here if you don't want to wait for me. |
|
While working on this, I ran into some issues supporting multiple players on the same page. Do we actually need this feature? It's not that hard, but it adds extra complexity and makes future changes a bit messier. Even when I had two friends streaming, I'd usually just open another tab and split the view so never used it myself. |
|
@sleroq Would it be easy to disable chat when multi player is enabled? It was requested by multiple people would hate to lose it :( But do anything to remove/complexity make initial merge easy! I want to get your code in so you get that joy of seeing it merged :) and we can iterate from there |
|
@sleroq is that an ok option? |
|
It's already implemented in this PR, chat is togglable via button inside of the player. @Sean-Der |
|
Great! Tell me what I can do to help. I’m |
This avoids remouting the first player when adding more streams
2 participants
No description provided.