Visually indicate unavailable player features#398
Open
neckro wants to merge 1 commit intoGlimesh:mainfrom
Open
Visually indicate unavailable player features#398neckro wants to merge 1 commit intoGlimesh:mainfrom
neckro wants to merge 1 commit intoGlimesh:mainfrom
Conversation
neckro
commented
Aug 23, 2025
neckro
commented
- fade requestPictureInPicture button when not supported (ex. Firefox)
- similarly fade requestFullscreen button (ex. Safari)
- fade quality selector button when not available
- add pointer cursor when these buttons are clickable
- fade requestPictureInPicture button when not supported (ex. Firefox) - similarly fade requestFullscreen button (ex. Safari) - fade quality selector button when not available - add pointer cursor when these buttons are clickable
Collaborator
|
I feel terrible that I missed this @neckro! This an awesome improvement, are you still interested in merging these? Would you be interested in rebasing/making sure the changes match what you intended? I can merge it myself if you don't have the time. The second you are happy with it I will merge it. Sorry again I missed it. I am trying my best to get a great v2.0.0 release :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.