changed some logic regarding restarting a stream, streams being deleted#336
Merged
Sean-Der merged 1 commit intoGlimesh:mainfrom Jun 16, 2025
Merged
changed some logic regarding restarting a stream, streams being deleted#336Sean-Der merged 1 commit intoGlimesh:mainfrom
Sean-Der merged 1 commit intoGlimesh:mainfrom
Conversation
Collaborator
|
Amazing debugging. Thank you @Criveratech |
Collaborator
|
I’m going to add a test and get this merged |
Sean-Der
force-pushed
the
main
branch
2 times, most recently
from
06ea581 to
8a00632
Compare
Old WHIP sessions would incorrectly cause new ones to get deleted. This adds ID to WHIP sessions so we can properly identify them when cleaning up. Resolves Glimesh#296
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed handling of streams being dropped/recreated when reconnecting.
Before if we e.g restart the stream in obs, obs doesn't actually reconnect, it just starts a new stream.
This results in bbox replacing the stream object, but never disposing of the old peerconnection.
The old peerconnection then goes into ICE disconnect->failed and bbox disposes of the stream in the status api.
This PR should fix that so that when a stream with the same streamkey as an existing one is added, it replaces the existing streams peerconnection, and disposes of the old one. Which should result in existing viewers "reconnecting" and the stream staying live in the status api.