Skip to content

Backport PR #659: ⬆️ dep-bump: python 3.14#661

Merged
nstarman merged 1 commit into
GalacticDynamics:versions/v1.11.xfrom
nstarman:versions/v1.11.x
May 8, 2026
Merged

Backport PR #659: ⬆️ dep-bump: python 3.14#661
nstarman merged 1 commit into
GalacticDynamics:versions/v1.11.xfrom
nstarman:versions/v1.11.x

Conversation

@nstarman
Copy link
Copy Markdown
Contributor

@nstarman nstarman commented May 8, 2026

  • ⬆️ dep-bump: python 3.14
  • 🐛 fix: py3.14 changes to dataclass construction

Replace direct Field(...) constructor calls (fragile positional args) with field(...) keyword calls in astropy interop modules.

Guard __init_subclass__ in AbstractUnitSystem against the intermediate make_dataclass(slots=True) call in Python 3.14+ where __annotate_func__ is not yet present, preventing premature processing of missing annotations (PEP 749 / __annotate_func__).

Make equality with StaticValue work for static arguments through JIT.

(cherry picked from commit 0a1c53e)

* ⬆️ dep-bump: python 3.14
* 🐛 fix: py3.14 changes to dataclass construction

Replace direct `Field(...)` constructor calls (fragile positional args) with `field(...)` keyword calls in astropy interop modules.

Guard `__init_subclass__` in `AbstractUnitSystem` against the intermediate `make_dataclass(slots=True)` call in Python 3.14+ where `__annotate_func__` is not yet present, preventing premature processing of missing annotations (PEP 749 / `__annotate_func__`).

Make equality with `StaticValue` work for static arguments through JIT.

Signed-off-by: nstarman <nstarman@users.noreply.github.com>
(cherry picked from commit 0a1c53e)
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@nstarman nstarman added this to the v1.11.x milestone May 8, 2026
@nstarman nstarman requested a review from a team as a code owner May 8, 2026 20:49
@github-actions github-actions Bot added 📝 Add / update documentation Add or update documentation. 👷 Add / update CI build system Add or update CI build system. 🔧 Add / update configuration Add or update configuration files. ✅ Add / update / pass tests Add, update, or pass tests. labels May 8, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

❌ Patch coverage is 93.18182% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (versions/v1.11.x@6a03319). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/unxt/_src/quantity/value.py 72.72% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##             versions/v1.11.x     #661   +/-   ##
===================================================
  Coverage                    ?   96.03%           
===================================================
  Files                       ?       46           
  Lines                       ?     2445           
  Branches                    ?      130           
===================================================
  Hits                        ?     2348           
  Misses                      ?       72           
  Partials                    ?       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nstarman nstarman merged commit 0be3fdc into GalacticDynamics:versions/v1.11.x May 8, 2026
52 of 54 checks passed
@nstarman nstarman deleted the versions/v1.11.x branch May 8, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👷 Add / update CI build system Add or update CI build system. 🔧 Add / update configuration Add or update configuration files. 📝 Add / update documentation Add or update documentation. ✅ Add / update / pass tests Add, update, or pass tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant