Skip to content

⬆️ dep-bump: py3.14 support#515

Merged
nstarman merged 1 commit intoGalacticDynamics:mainfrom
nstarman:py314
May 9, 2026
Merged

⬆️ dep-bump: py3.14 support#515
nstarman merged 1 commit intoGalacticDynamics:mainfrom
nstarman:py314

Conversation

@nstarman
Copy link
Copy Markdown
Contributor

@nstarman nstarman commented May 8, 2026

No description provided.

@nstarman nstarman added this to the v0.23.x milestone May 8, 2026
@nstarman nstarman requested a review from a team as a code owner May 8, 2026 21:24
Copilot AI review requested due to automatic review settings May 8, 2026 21:24
@github-actions github-actions Bot added 🔧 Add / update configuration Add or update configuration files. 👷 Add / update CI build system Add or update CI build system. ⬆️ Upgrade dependencies Upgrade dependencies. labels May 8, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Coordinax’s packaging metadata and CI matrix to explicitly support Python 3.14, along with dependency minimum bumps likely required for 3.14 compatibility.

Changes:

  • Add Python 3.14 classifiers across workspace packages and include 3.14 in the CI test matrix.
  • Bump minimum versions for key runtime deps (quax/quax-blocks/quaxed/unxt) and switch to plum-dispatch with a Python-3.14-specific minimum version.
  • Pin the re-actors/alls-green GitHub Action to a specific commit hash.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pyproject.toml Adds Python 3.14 classifier; updates core dependency constraints (incl. conditional plum-dispatch and bumps for quax/quaxed/unxt).
packages/coordinax.interop.astropy/pyproject.toml Updates plum-dispatch and unxt requirements with Python 3.14 conditional.
packages/coordinax.hypothesis/pyproject.toml Adds Python 3.14 classifier.
packages/coordinax.curveframes/pyproject.toml Adds Python 3.14 classifier.
packages/coordinax.astro/pyproject.toml Adds Python 3.14 classifier.
packages/coordinax.api/pyproject.toml Adds Python 3.14 classifier; updates plum-dispatch requirement with Python 3.14 conditional.
.github/workflows/ci.yml Expands CI to test Python 3.14; pins alls-green action by commit SHA.

@github-actions github-actions Bot added 📝 Add / update documentation Add or update documentation. ✅ Add / update / pass tests Add, update, or pass tests. labels May 9, 2026
@nstarman nstarman force-pushed the py314 branch 3 times, most recently from d4111a7 to 7aa191e Compare May 9, 2026 03:40
@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026

Codecov Report

❌ Patch coverage is 95.32710% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.33%. Comparing base (dfdd737) to head (9c6566d).

Files with missing lines Patch % Lines
...s/src/coordinax/hypothesis/distances/_src/utils.py 0.00% 1 Missing ⚠️
src/coordinax/charts/_src/product.py 50.00% 1 Missing ⚠️
src/coordinax/manifolds/_src/base.py 75.00% 1 Missing ⚠️
src/coordinax/transforms/_src/actions/translate.py 0.00% 1 Missing ⚠️
src/coordinax/vectors/_src/point.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
+ Coverage   92.31%   92.33%   +0.02%     
==========================================
  Files         218      218              
  Lines        6633     6638       +5     
==========================================
+ Hits         6123     6129       +6     
+ Misses        510      509       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 60 out of 61 changed files in this pull request and generated 3 comments.

Comment thread pyproject.toml
Comment on lines 22 to +36
dependencies = [
"astropy>=7.0.0",
"beartype>=0.21.0",
"coordinax.api",
"dataclassish>=0.8.0",
"equinox>=0.13.2",
"dataclassish>=0.8.0,<0.9.0; python_version == '3.11'",
"dataclassish>=0.9.0; python_version >= '3.12'",
"equinox>=0.13.8",
"jax>=0.6.0",
"jaxlib>=0.6.0",
"jaxtyping>=0.3.3",
"optional-dependencies>=0.3.2",
"plum>=2.8.0",
"quax>=0.2.1",
"quax-blocks>=0.4.0",
"quaxed>=0.10.4",
"plum>=2.8.0; python_version < '3.14'",
"plum>=2.9.0; python_version >= '3.14'",
"quax>=0.3.2",
"quax-blocks>=0.4.1",
Comment on lines +63 to +67
def __call__(self, tau: Any, x: Any = None, /, **kw: Any) -> Any:
"""Apply the operator to the arguments.

This method calls `coordinax.api.frames.act` to apply the operator.
If `x` is not provided, `tau` will be passed as `None` to the `act`
Comment thread docs/conventions.md
# CORRECT
@plum.dispatch
def process(obj: cxc.AbstractChart, /): # type: ignore[type-arg]
def process(obj: cxc.AbstractChart, /):
@nstarman nstarman merged commit 104bfe0 into GalacticDynamics:main May 9, 2026
22 checks passed
@nstarman nstarman deleted the py314 branch May 9, 2026 05:05
@lumberbot-app
Copy link
Copy Markdown

lumberbot-app Bot commented May 9, 2026

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout versions/v0.23.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 104bfe0be71e6a1895f0a97823e770fcb6107e72
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #515: ⬆️ dep-bump: py3.14 support'
  1. Push to a named branch:
git push YOURFORK versions/v0.23.x:auto-backport-of-pr-515-on-versions/v0.23.x
  1. Create a PR against branch versions/v0.23.x, I would have named this PR:

"Backport PR #515 on branch versions/v0.23.x (⬆️ dep-bump: py3.14 support)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👷 Add / update CI build system Add or update CI build system. 🔧 Add / update configuration Add or update configuration files. 📝 Add / update documentation Add or update documentation. ✅ Add / update / pass tests Add, update, or pass tests. ⬆️ Upgrade dependencies Upgrade dependencies.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants