Skip to content

Fix/dupe state#974

Merged
bryceknz merged 5 commits into
mainfrom
fix/dupe-state
May 19, 2026
Merged

Fix/dupe state#974
bryceknz merged 5 commits into
mainfrom
fix/dupe-state

Conversation

@fant0mex
Copy link
Copy Markdown
Contributor

@fant0mex fant0mex commented May 15, 2024

Fixes #965
Fixes #1114

Description

Removes state and nonce from iOS additionalParameters after reading them, so they are not sent twice to AppAuth-iOS.

This matches the existing Android behavior and fixes Google errors like:

OAuth 2 parameters can only have a single value: state
OAuth 2 parameters can only have a single value: nonce

Verification

Manually verified in the iOS demo app using Google auth:

  • additionalParameters.state completes without a duplicate state error.
  • additionalParameters.nonce completes without a duplicate nonce error.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 15, 2024

🦋 Changeset detected

Latest commit: e838d7d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-native-app-auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bryceknz
Copy link
Copy Markdown
Contributor

Hey @fant0mex, long time no chat! I'm picking this PR up -- hope you don't mind. I'll make sure you get git credit 😊

I've rebased/merged it forward locally, kept your original state fix, and will add the matching nonce fix for #1114 since it has the same root cause.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-native-app-auth Ready Ready Preview, Comment May 18, 2026 2:00pm

Request Review

@bryceknz bryceknz merged commit 94f7c87 into main May 19, 2026
3 checks passed
@bryceknz bryceknz deleted the fix/dupe-state branch May 19, 2026 10:05
@github-actions github-actions Bot mentioned this pull request May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate nonce if custom nonce is set on iOS Sign in with Google on iOS with predefined state not possible

2 participants