feat: experimentation flagsmith warehouse setup api scaffolding#7542
feat: experimentation flagsmith warehouse setup api scaffolding#7542Zaimwa9 wants to merge 9 commits into
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
for more information, see https://pre-commit.ci
Docker builds report
|
…:Flagsmith/flagsmith into feat/experimentation-warehouse-setup-api
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
|
Visual Regression19 screenshots compared. See report for details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7542 +/- ##
========================================
Coverage 98.47% 98.48%
========================================
Files 1400 1413 +13
Lines 53036 53329 +293
========================================
+ Hits 52226 52519 +293
Misses 810 810 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| "uuid", | ||
| models.UUIDField(default=uuid.uuid4, editable=False, unique=True), |
There was a problem hiding this comment.
I hesitated between UUID and integerID, let me know what you think
There was a problem hiding this comment.
I prefer int because uuid takes a lot more space, but either is fine here, doesn't make much of a difference.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to #7278 #7279
Adds the experimentation Django app with a WarehouseConnection model and CRUD endpoints for V1 (Flagsmith hosted warehouse type only).
WarehouseConnectionViewSet(List, Create, Retrieve, Destroy) atenvironments/<env_api_key>/warehouse-connections/. Soft-delete resurrection on re-creation. 409 on duplicate.WarehouseConnectionPermission— Feature flag + environment admin check.RelatedObjectType.WAREHOUSE_CONNECTION.How did you test this code?
feat/experimentation-warehouse-setup