feat: added configurable redis cache for shared redis instances#7529
Open
SahilJat wants to merge 1 commit into
Open
feat: added configurable redis cache for shared redis instances#7529SahilJat wants to merge 1 commit into
SahilJat wants to merge 1 commit into
Conversation
|
@SahilJat is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
fa0db2b to
5c033c9
Compare
5c033c9 to
3c1c294
Compare
Contributor
Author
|
Hii alll the test cases has been passed , the test that failed is already exisiting issue mentioned here #7368 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Closes #7297
Adds a
CACHE_KEY_PREFIXenvironment variable that setsKEY_PREFIXon all Redis-backed cache entries in theCACHESdict.CACHE_KEY_PREFIX = env.str("CACHE_KEY_PREFIX", default="")toapi/app/settings/common.pyCACHESentries are defined (including SAML) that appliesKEY_PREFIX = CACHE_KEY_PREFIXto any cache whoseBACKENDcontains"redis"(case-insensitive)With
CACHE_KEY_PREFIX=flagsmith, Redis keys becomeflagsmith:1:environment_document_xxxinstead of:1:environment_document_xxx, enabling Redis ACL rules like~flagsmith:*for namespace-based multi-tenancy.How did you test this code?
api/tests/unit/app/test_unit_app_settings.py:KEY_PREFIXappliedKEY_PREFIXto empty stringCACHE_KEY_PREFIX=flagsmith python -c "from app.settings.common import CACHES"api/tests/unit/app/pass