Skip to content

Restrict missing software check to after deploy label is set#1505

Draft
ocaisa wants to merge 14 commits into
EESSI:mainfrom
ocaisa:restrict_missing_check
Draft

Restrict missing software check to after deploy label is set#1505
ocaisa wants to merge 14 commits into
EESSI:mainfrom
ocaisa:restrict_missing_check

Conversation

@ocaisa
Copy link
Copy Markdown
Member

@ocaisa ocaisa commented May 20, 2026

No description provided.

@ocaisa ocaisa force-pushed the restrict_missing_check branch from e01ba8e to 2cceb6e Compare May 20, 2026 07:59
@ocaisa ocaisa added the force-ci-checks Force missing software CI checks for a PR label May 20, 2026
Comment thread .github/workflows/test-software.eessi.io.yml Outdated
@ocaisa ocaisa removed the force-ci-checks Force missing software CI checks for a PR label May 20, 2026
@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented May 20, 2026

To whomever reviews this, you can see that the the missing installation test is currently skipped. To force the check to run you add the label force-ci-checks.

However, I would like to also make sure that we require the missing installations check before a PR is merge-able (which it seems like is not quite the status)

@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented May 20, 2026

Actually, it seems the the required checks are indeed held back, this PR should not be mergable even with a positive review

@ocaisa ocaisa marked this pull request as draft May 25, 2026 09:26
@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented May 25, 2026

I'm going to take this further, I plan to

  • Only run the consistency check after the missing installations check has succeeded
  • Reduce the number of CI jobs to architecture families only (our missing installations and consistency checks only require pure python or shell commands so are actually architecture independent to that level)

@ocaisa ocaisa added force-ci-checks Force missing software CI checks for a PR and removed force-ci-checks Force missing software CI checks for a PR labels May 25, 2026
@ocaisa ocaisa added the force-ci-checks Force missing software CI checks for a PR label May 25, 2026
@ocaisa ocaisa added force-ci-checks Force missing software CI checks for a PR and removed force-ci-checks Force missing software CI checks for a PR labels May 25, 2026
@ocaisa ocaisa removed the force-ci-checks Force missing software CI checks for a PR label May 25, 2026
@ocaisa ocaisa added force-ci-checks Force missing software CI checks for a PR and removed force-ci-checks Force missing software CI checks for a PR labels May 25, 2026
@ocaisa ocaisa added the force-ci-checks Force missing software CI checks for a PR label May 25, 2026
@ocaisa ocaisa added force-ci-checks Force missing software CI checks for a PR and removed force-ci-checks Force missing software CI checks for a PR labels May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

force-ci-checks Force missing software CI checks for a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant